Add subcommand to dump task profile urls#1173
Merged
Conversation
mdellweg
force-pushed
the
task_profiling
branch
from
fac3d1d to
b350c2c
Compare
mdellweg
force-pushed
the
task_profiling
branch
from
b350c2c to
1b2754d
Compare
dralley
reviewed
Apr 17, 2025
| uuid = uuid_match.group("uuid") | ||
| with requests.session() as session: | ||
| for name, url in urls.items(): | ||
| profile_artifact_path = Path(".") / f"task-{uuid}-{name}" |
Contributor
There was a problem hiding this comment.
I'm not against this structure necessarily, but wdyt about creating a directory named task-{uuid} and putting artifacts inside it?
Contributor
There was a problem hiding this comment.
or even {task_name} - {uuid}.
Member
Author
There was a problem hiding this comment.
Creating a deeper directory structure is mainly a matter of taste...
Please have another look.
Contributor
There was a problem hiding this comment.
It's a matter of taste until there's more than one or two artifacts being generated, then it's a practical matter
mdellweg
force-pushed
the
task_profiling
branch
from
1b2754d to
8dc6fcd
Compare
mdellweg
force-pushed
the
task_profiling
branch
from
8dc6fcd to
b1bfc28
Compare
dralley
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1172